fix: refresh pointer offsets after layout changes - #62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving a remote-controlled area without resizing it (for example, docking a panel or scrolling its container) leaves the cached element offset stale. Subsequent pointer events then report coordinates relative to the old position.
Refresh the viewport offset when converting each pointer event. This fixes the shared controller used by both React and Vue without requiring a resize event or sending extra size updates.
Note: The failing distance-widget test appears timing-sensitive: its fixed sleeps can expire before RCA finishes processing the queued mouse events. The test now waits for VTK to process the expected mouse releases, with a five-second timeout, while preserving the distance assertions. All eight interaction tests pass locally, and both Vue and React distance tests also pass with an increased event throttle. CI Passes now.