Conversation
Also, get rid of kotlin-test in core, it's now redundant
This is presumably safe due to google/truth@948f3ed
qwwdfsad
commented
Jul 31, 2026
| testImplementation(libs.junit) | ||
| testImplementation(platform(libs.junit.bom)) | ||
| testImplementation(libs.googleTruth) { | ||
| exclude(group = "junit", module = "junit") |
Member
Author
There was a problem hiding this comment.
See google/truth#333 and https://github.com/google/truth/blob/18fafefc293fd624a5291cda8da42356401650eb/core/src/main/java/com/google/common/truth/Platform.java#L264-L280
My suggestion is to get rid of Truth to moment we have any JUnit4/linkage errors in the build
qwwdfsad
commented
Jul 31, 2026
| gson = { module = "com.google.code.gson:gson", version.ref = "com-google-code-gson-gson" } | ||
| guava = { module = "com.google.guava:guava", version.ref = "com-google-guava-guava" } | ||
| junit = { module = "junit:junit", version.ref = "junit-junit" } | ||
| junit-bom = { module = "org.junit:junit-bom", version.ref = "org-junit-junit-bom" } |
Member
Author
There was a problem hiding this comment.
If you are puzzled by the convention between dashes and camel case, it makes two of us now: https://docs.gradle.org/current/userguide/best_practices_dependencies.html#name_version_catalog_entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few notes:
This is a basis for the next PR with tests revamp (and it's more pleasant to do it with JUnit 6 + it's always nice to renovate things) and a nice testing ground for stacked PRs