Smartstack - image stacking#469
Open
timbeccue wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of four PRs that can be reviewed independently in service of smartstacking now that the scaffolding is in place.
The calibration stacking code has been refactored so that it can be reused for smartstacking as well. Added method="sum" for smartstacks, in addition to the existing mean capabilities used for calibrations.
I've included regression coverage with the prior implementation in pre_refactor_stack_snapshot to demonstrate that behavior for calibration frames has not changed. Is this useful to keep around long term?
I have _warn_if_exposure_times_differ for all stacks, which issues a warning if exposures times differ by more than 1%. If calibration frames use different exposure times then I can have this only run for smartstacks.