Allow database creation with only create permissions#190
Open
lostcarpark wants to merge 1 commit into
Open
Conversation
…ly require create permissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most recent database dumps contain statements that require root permissions to execute. These are around security definers for triggers and views, that would allow the trigger/view to access tables the user doesn't have access to. In our case, we are assuming one user for all database operations, as this is the only option for many shared hosting plans. This change ensures that a user with general "create" permissions but no other special privileges can create the databases.
For the future, it might be worth looking at providing creation scripts that set up the database in a way that the application user could have minimal permissions, so that if an attacker were to gain access to the SQL user (for example, through a SQL injection attack), the damage they could cause would be limited. However, I think this would have to be an optional creation script to not exclude low-cost shared hosting plans.