Dev cami#6
Open
Mcarrobof24 wants to merge 18 commits into
Open
Conversation
-favicon added as well -viewport
-Components folder added -data folder and dataset.js added -lib folder and dataFunctions.js, api.js files added -views folder with their views/components files added -router file added -style.css added -test folder added -Cards.js html added but to be reviewed -index.js to be reviewed -Home.js to be reviewed
router.js file has the following characteristics: - Store application routes. - For a given route in the URL, generate the appropriate view. - Respond to in-app navigation. - Loading an error page. - Respond to forward and back navigation in the browser
- Add file error test
-router.js: setRootEl(newRootElvalue), setRoutes(newRoutesValue),
renderView(pathname, props={}), navigateTo(pathname, props),
onURLChange(location) functions created
-index.js: routes defined in router, "root element" passed to router,
router invoque view rendering
-Home, Cards, Error views created -Footer component created -index.html: script source changed to index.js
Author
|
ok |
1 similar comment
Author
|
ok |
- StyleHome.css file deleted. - views/Home.js added classes for styles.
- addEventListener in BUTTON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.