Skip to content

Order Arrow CSR metadata test #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 2 commits into from
May 25, 2026
+14 −5
Merged

Order Arrow CSR metadata test #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd98e6f
Order Arrow CSR metadata test
adsharma May 25, 2026
c1c636e
Save Windows ccache after CI failures
adsharma May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,14 +172,15 @@ jobs:
ccache --set-config=cache_dir=D:\c
ccache --set-config=temporary_dir=D:\t

- name: Cache ccache directory (Windows)
- name: Restore ccache directory (Windows)
if: matrix.platform == 'windows'
uses: actions/cache@v4
uses: actions/cache/restore@v4
with:
path: D:\c
key: minimal-test-${{ runner.os }}-${{ github.ref }}
key: minimal-test-${{ runner.os }}-${{ github.ref }}-${{ github.run_id }}-${{ github.run_attempt }}
restore-keys: |
minimal-test-${{ runner.os }}-refs/heads/main
minimal-test-${{ runner.os }}-${{ github.ref }}-
minimal-test-${{ runner.os }}-refs/heads/main-
minimal-test-${{ runner.os }}-

- name: Enable long paths (Windows)
Expand Down Expand Up @@ -245,6 +246,13 @@ jobs:
uv pip install pytest pexpect
make shell-test test

- name: Save ccache directory (Windows)
if: always() && matrix.platform == 'windows'
uses: actions/cache/save@v4
with:
path: D:\c
key: minimal-test-${{ runner.os }}-${{ github.ref }}-${{ github.run_id }}-${{ github.run_attempt }}

minimal-linux-extension-test:
name: minimal linux extension test
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion test/api/arrow_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ TEST_F(ArrowTest, queryAsArrowDirectCSRRowIDProjection) {
}

TEST_F(ArrowTest, queryAsArrowDirectCSRRowIDProjectionKeepsCSRMetadataWithFourThreads) {
auto query = "MATCH (a:person)-[b:knows]->(c:person) RETURN a.rowid, b.rowid, c.rowid";
auto query = "MATCH (a:person)-[b:knows]->(c:person) RETURN a.rowid, b.rowid, c.rowid "
"ORDER BY a.rowid, b.rowid, c.rowid";
conn->setMaxNumThreadForExec(4);
auto result = conn->queryAsArrow(query, 8);
auto* arrowResult = dynamic_cast<ArrowQueryResult*>(result.get());
Expand Down
Loading