[lua] Energetic Eruca Audits pt. 2#10154
Open
KiplingFFXI wants to merge 1 commit into
Open
Conversation
Xaver-DaRed
reviewed
May 27, 2026
| elseif dayElement ~= xi.element.FIRE and mobArg:getMod(xi.mod.REGAIN) ~= 0 then | ||
| mobArg:setMod(xi.mod.REGAIN, 0) | ||
| end | ||
| end) |
Contributor
There was a problem hiding this comment.
What if day changes mid-battle, does it not gain regain?
Also, this doesnt need to be a listener, just place it in onMobRoam
And while we are at it, store the mod value in a var aswell so we dont fetch it 2 times.
KiplingFFXI
force-pushed
the
Energetic-Eruca-Audits-pt.-2
branch
from
c6f953d to
d6d2047
Compare
Co-authored-by: Skold177 <113406182+Skold177@users.noreply.github.com>
KiplingFFXI
force-pushed
the
Energetic-Eruca-Audits-pt.-2
branch
from
d6d2047 to
72aeb1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR is related to #10150 - I realized I forgot to include the Eruca family behavior of TP regain on Firesday. However, I did not add the Eruca family mixin specifically because this NM does not go to sleep and become non-aggressive during certain game hours. It only needs the TP regain behavior, so I've added it into the NMs lua instead.
I do not have a recorded capture of the above behavior but it is corroborated by JP wiki.
Steps to test these changes
!spawnmob ID 17027466 and witness the changes.