Clean up F1ServerApp: dead code, orphaned assets, inline styles - #592
Merged
Conversation
Resolves a batch of low-severity findings from the frontend review report. Removes CSS rules and markup attributes that the templates never use (championships, statistics, tracks components), drops dead "Loading..." guards for fields that are always initialized, and moves the Material Symbols font link and a couple of global element selectors out of component templates/styles into index.html/styles.css. Populates the previously empty championship difficulty column, replaces extensive inline style attributes with CSS classes in the sessions, create championship and show session components, and removes assets that are referenced nowhere in the app (flag SVGs, legacy live status PNGs, telemetry.png). Resizes the oversized tyre_hypersoft.png down to match its sibling tyre assets, and documents the still-missing track map images for the short-layout circuits as a known gap. Closes #261, #263, #264, #265, #271, #279, #288, #290, #292, #299, #300, #301, #302, #303
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Resolves a batch of low-severity findings from the frontend review report (
docs/review/FINDINGS-OVERVIEW.md), all scoped toF1ServerApp:championships.component.css(deleted, was a copy ofstatistics.component.css), the unusedtitle-*/loader/hcenter/@keyframes spinrules instatistics.component.css, and the unusedlayout-row/cards-*/track-card/track-container/track-row/track-column*/track-table/track-th/track-tdrules intracks.component.css.layout="row"attribute intracks.component.html(no effect without@angular/flex-layout).entry.raceDifficulty.styleattributes with CSS classes insessions.component.html,createchampionship.component.html(newcreatechampionship.component.css) andshowsession.component.html.@if (!x) { Loading... }guards inlivesession,lastsession,gamesandtracksessionscomponents, since the underlying fields are always initialized (constructor-instantiated or default[]/Set). Also fixes the inconsistent guarding ofaiDifficultyinlastsession.component.html.nav-menu.component.htmlandsessions.component.htmlintoindex.html, and moves the globalhtml/bodyelement selectors out ofnav-menu.component.css(intostyles.css) andtracksessions.component.css(already duplicated instyles.css, so just removed there).flags/SVG directory, the legacylive_on/live_offPNGs, andtelemetry.png.tyre_hypersoft.pngfrom 457×457 (327 KB) down to 200×200 (~70 KB), matching its sibling tyre assets.🎫 Issues
Closes #261, Closes #263, Closes #264, Closes #265, Closes #271, Closes #279, Closes #288, Closes #290, Closes #292, Closes #299, Closes #300, Closes #301, Closes #302, Closes #303
👩💻 Reviewer Notes
All changes are visual/dead-code cleanup with no intended behavior change, except the championship difficulty column (now shows a value) and the tyre_hypersoft.png resize (visually identical at the small display size it's used at). Worth a quick smoke test of the Sessions, Championships, Tracks, Statistics, Games, Track sessions and Nav menu pages.
📑 Test Plan
Manually reviewed each affected template/stylesheet against its usage to confirm no visual regression, and confirmed the Angular app still compiles.
✅ Checklist
General
Frontend-specific (Angular)
Data/ViewDatacontracts.⏭ Next Steps
Sourcing real track map artwork for the short-layout circuits (track IDs 23–26) is left as follow-up, since no map source was available in this change.