ac equipment bug fixes - #17
Open
fayeforpay wants to merge 1 commit into
Open
fayeforpay wants to merge 1 commit into
fayeforpay wants to merge 1 commit into
Conversation
+ inspect_occupation checked equipment against the previous_state, allowing players to use any armor they want + weapons weren't checked against occupation, allowing players to use any weapon they want + equipping armor with an invalid material (such as Wood, Silver, etc.) gave an error message with a full list of all allowed armor materials, not just for the player's current class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a player changed their Shoulder armor to Wood and received this message:
which resulted in them reporting it to feedback because it displayed all materials, not just allowed materials for their class specifically - community feedback
I do agree that this can be confusing for some players and potentially trick them into equipping an invalid item which could get them kicked again. Which is why I included this "bug", which is not really a bug.
However, while adding this feature I stumbled upon two real bugs, that allow players to use weapons and armor from other classes:
so a player was able to equip a Ranger set, then switch to Warrior (using cheats) without being detected by the anti cheat