Skip to content

馃Ь fix: Reconcile Deleted Code Session Files #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny-avila merged 5 commits into from
Sep 14, 2026
Merged

馃Ь fix: Reconcile Deleted Code Session Files #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
59362b5
fix: persist code session file deletions
danny-avila Sep 14, 2026
90152e0
fix: reconcile concurrent session deletions
danny-avila Sep 14, 2026
2afea34
fix: preserve deletion identity across tool lifecycles
danny-avila Sep 14, 2026
a4d20f7
fix: reconcile inherited and idless code calls
danny-avila Sep 14, 2026
5470202
fix: normalize legacy inherited echoes
danny-avila Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/tools/BashExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,10 @@ function createBashExecutionTool(
artifactDelivery
);
const hasFiles = result.files != null && result.files.length > 0;
const deletionEcho =
result.deleted_files != null
? { deleted_files: result.deleted_files }
: {};
const runtimeEcho =
result.runtime_session_id != null
? {
Expand All @@ -419,13 +423,15 @@ function createBashExecutionTool(
...(artifactDelivery != null
? { artifact_delivery: artifactDelivery }
: {}),
...deletionEcho,
...runtimeEcho,
}
: {
session_id: result.session_id,
...(artifactDelivery != null
? { artifact_delivery: artifactDelivery }
: {}),
...deletionEcho,
...runtimeEcho,
}) satisfies t.CodeExecutionArtifact,
];
Expand Down
6 changes: 6 additions & 0 deletions src/tools/CodeExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,10 @@ function createCodeExecutionTool(
artifactDelivery
);
const hasFiles = result.files != null && result.files.length > 0;
const deletionEcho =
result.deleted_files != null
? { deleted_files: result.deleted_files }
: {};
/* Echo the durable runtime session (stateful backends only) so hosts
* can surface a "session active / was reset" signal later. Additive:
* absent on stateless servers. */
Expand All @@ -691,13 +695,15 @@ function createCodeExecutionTool(
...(artifactDelivery != null
? { artifact_delivery: artifactDelivery }
: {}),
...deletionEcho,
...runtimeEcho,
}
: {
session_id: result.session_id,
...(artifactDelivery != null
? { artifact_delivery: artifactDelivery }
: {}),
...deletionEcho,
...runtimeEcho,
}) satisfies t.CodeExecutionArtifact,
];
Expand Down
3 changes: 3 additions & 0 deletions src/tools/ProgrammaticToolCalling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,6 +954,9 @@ export function formatCompletedResponse(
{
session_id: response.session_id,
files: response.files,
...(response.deleted_files != null
? { deleted_files: response.deleted_files }
: {}),
...(artifactDelivery != null
? { artifact_delivery: artifactDelivery }
: {}),
Expand Down
Loading
Loading