feat: Run PTC in Selected BYOM Workspaces - #195
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 786282d398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89cac159dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e18c37929e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
code-interpreter/packages/code/src/native-process.ts
Lines 254 to 255 in 64c22b8
Preserve clean pre-dispatch failures across executor IPC
When the child rejects before starting either sandbox pass—for example, an input download fails, aggregate input validation rejects the request, or the copy-on-write clone is unavailable—it reports both mutation: false and requiresQuarantine: false. This reconstruction nevertheless sets requiresQuarantine for every non-cancellation programmatic RPC because pending.mutation is always true and processTerminationConfirmed only recognizes EXECUTION_ABORTED; BridgeWorker then retains the already-armed durable guard and quarantines a workspace that was never touched. Honor the child's clean classification whenever message.mutation === false, while continuing to fail closed for genuinely ambiguous post-dispatch failures.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed the review-body P1 in 6133b7d: the parent IPC layer now honors a child-reported mutation=false for every clean pre-dispatch failure, not only cancellation, and retains fail-closed quarantine for ambiguous post-dispatch failures. Focused coverage exercises the preserved classification. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6133b7d4b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please review the current PR head ab15095. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads. This round addresses all nine outstanding findings across replay isolation, trusted dependency discovery, reserved control files, file and transfer budgets, and single-slot result finalization. The real SRT canary exposed that per-command network overrides do not tighten the manager's proxy/socket policy. Probes now restrict the session and revoke its proxy endpoints before restoring the commit policy. The opt-in live regression passes with one external POST and one workspace write, including the trusted-vm policy. Please scrutinize the ownership transitions and mixed capability paths, especially speculative execution versus committed effects, transfer budgeting before manifest signing, and workspace fencing through artifact restoration. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
danny-avila
changed the title
1 participant
Summary
Compatibility
Focused verification
npm run build && node --test dist/native-programmatic.test.js dist/native-process.test.js dist/protocol.test.js dist/workspace-worker.test.js dist/worker-slots.test.js(82 passing)bun test src/bridge/workspace-store.test.ts src/preamble-bash.test.ts src/sandbox-backend/remote-bridge.test.ts src/service/programmatic-state.test.ts(54 passing)Scale and security boundaries