Skip to content

feat: Report Deleted Code Session Files - #200

Merged
danny-avila merged 4 commits into
mainfrom
danny-avila/persist-code-session-deletions
Sep 14, 2026
Merged

danny-avila merged 4 commits into
mainfrom
danny-avila/persist-code-session-deletions

Conversation

@danny-avila

@danny-avila danny-avila commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • report persisted input paths removed during sandbox execution through an optional deleted_files response field
  • propagate deletion metadata through blocking, stateful, and selected-workspace native programmatic responses
  • reconcile against complete bounded filesystem scans, including capped subtrees and reserved runtime filenames
  • preserve read-only infrastructure inputs and clear stale stateful priming only for proven writable deletions

Compatibility

The field is additive and omitted for unchanged sessions and incomplete scans. Existing clients continue to receive the current response shape.

Paired consumer: LibreChat-AI/agents#545. Either PR is rolling-deploy safe first; merging this producer first makes the feature active as soon as the consumer ships.

Tests

  • bun test api/src/walker.test.ts (67 passed)
  • focused stateful workspace tests
  • selected-workspace native programmatic tests (14 passed)
  • focused blocking-poll propagation tests
  • API and @librechat/code builds
  • GitHub Actions validation matrix

@danny-avila danny-avila changed the title Persist deleted code session files 🪦 feat: Report Deleted Code Session Files Sep 14, 2026
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 97d6331. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T19:43:17.720869Z b31c942 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97d633171a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread service/src/workers.ts
Comment thread api/src/job.ts Outdated
Comment thread api/src/job.ts
Comment thread api/src/job.ts
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 0ea6cfb. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ea6cfb86e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/src/job.ts
Comment thread api/src/job.ts
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 1d078904c31128f310e58bd9d652f91b3357491a. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Correction to the immediately preceding request: please review the current PR head 1d07890. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d078900e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread api/src/job.ts Outdated
Comment thread api/src/job.ts
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head b31c942. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@danny-avila danny-avila changed the title 🪦 feat: Report Deleted Code Session Files feat: Report Deleted Code Session Files Sep 14, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: b31c942a37

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit 6ca38b2 into main Sep 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant