Skip to content

fix: Isolate Native PTC Readiness and Watchdog Phases - #208

Merged
danny-avila merged 1 commit into
mainfrom
danny-avila/fix-ptc-watchdog-readiness
Sep 14, 2026
Merged

danny-avila merged 1 commit into
mainfrom
danny-avila/fix-ptc-watchdog-readiness

Conversation

@danny-avila

Copy link
Copy Markdown
Collaborator

Summary

  • keep ordinary native workspace commands available when optional selected-workspace PTC dependencies or copy-on-write preflight are unavailable
  • give PTC staging and commit separate bounded watchdog budgets, using the protocol execution default when run_timeout is omitted
  • add an acknowledged IPC commit barrier so pre-commit failures remain mutation-atomic while post-barrier failures retain quarantine protection

Closes #201.
Closes #202.
Closes #203.

Focused verification

  • npm run build (packages/code)
  • node --test dist/native-process.test.js dist/native-programmatic.test.js dist/native-process-child.test.js dist/native-sandbox.test.js dist/native-pool.test.js (100 passed)
  • LIBRECHAT_CODE_LIVE_SRT_TESTS=1 node --test dist/native-programmatic-live.test.js (real macOS SRT; probe side effects blocked and commit executed once)
  • git diff --check

Codegraph test selection was unavailable on this host, so focused tests were selected from the affected native process, programmatic executor, sandbox, and pool dependency boundaries.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head bd8b1cc. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T19:50:43.588175Z bbc2f8d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: bd8b1cc131

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila force-pushed the danny-avila/fix-ptc-watchdog-readiness branch from bd8b1cc to bbc2f8d Compare September 14, 2026 19:47
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head bbc2f8d. This head rebases onto main after #206 and #207 and preserves trusted Bash/jq resolution while making PTC readiness lazy. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: bbc2f8d27e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit 10ac19b into main Sep 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant