Skip to content

fix: Allow Trusted Own-Root Environment Symlinks - #212

Merged
danny-avila merged 3 commits into
mainfrom
danny-avila/fix-environment-root-alias
Sep 15, 2026
Merged

danny-avila merged 3 commits into
mainfrom
danny-avila/fix-environment-root-alias

Conversation

@danny-avila

Copy link
Copy Markdown
Collaborator

Summary

  • Accept filesystem-identical own roots selected through trusted external symlinks.
  • Keep rejection of workspace-controlled descendant links and aliases crossing another registered root.
  • Add direct and chained external alias regression coverage.

Fixes #210.

Verification

  • Package TypeScript build passed.
  • 10 focused environment tests passed, including existing containment and identity checks.
  • No protocol or deployment configuration changes.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 4782cdf. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T23:59:55.808668Z d75bff9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4782cdf24d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/code/src/environment.ts Outdated
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head e3f8376. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3f8376a74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/code/src/environment.ts Outdated
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head d75bff9. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

Invariant audit: parent ownership is now checked for EVERY root traversal component and definition-control path, not only aliases targeting the root identity. Cached canonical parents and inode identities cover mixed-case, direct/chained aliases, intermediate pivots targeting external directories, and definition source traversal. Existing mount-topology checks remain unchanged. Focused 13-test environment/mount verification and package typecheck pass.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: d75bff9fcb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit f2dcb93 into main Sep 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symlinked environment roots fail own-root containment validation

1 participant