Skip to content

fix: Retain Quarantine After Failed Environment Setup - #213

Merged
danny-avila merged 3 commits into
mainfrom
danny-avila/fix-setup-quarantine
Sep 15, 2026
Merged

danny-avila merged 3 commits into
mainfrom
danny-avila/fix-setup-quarantine

Conversation

@danny-avila

Copy link
Copy Markdown
Collaborator

Summary

  • Clear the startup mutation marker only after setup exits successfully without a timeout.
  • Retain quarantine on nonzero exits, timeouts, and exceptions; explain inspection and reset in the startup error and docs.
  • Extend real native CLI coverage to verify failure retains the marker and a second startup cannot rerun setup.

Fixes #211.

Verification

  • Package TypeScript build passed.
  • Four opt-in real native SRT CLI tests passed locally: success, nonzero failure, timeout, and maintenance reset.
  • Failure cases verify durable quarantine and restart rejection before repeated mutation; success verifies marker removal before registration.
  • Existing operators must inspect failed setup before using the existing quarantine reset command. No server configuration changes.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head a8498d8. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T23:52:33.734804Z 88c776b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head f8ba126. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads. This head also runs the real native setup lifecycle regressions in macOS CI.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8ba12629a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/code/README.md Outdated
@danny-avila

Copy link
Copy Markdown
Collaborator Author

@codex review

Please review the current PR head 88c776b. Confirm that this exact commit is the reviewed commit and ignore findings that apply only to earlier heads.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 88c776b2b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila merged commit 840537b into main Sep 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timed-out environment setup clears its workspace quarantine marker

1 participant