Docs deploy skips pre-releases - #196
Merged
Merged
Conversation
`release: published` fires for pre-releases too — `released` is the type that skips them — so a `v0.5.0rc1` release would have run `mike deploy --update-aliases <version> latest` and `mike set-default`, serving rc docs as the site default. That is the opposite of the workflow's own rule that the site tracks the released CLI: PyPI hands an rc only to someone who asks for it by name, so the site must keep serving the last full release. One `if` on the deploy job. `github.event.release` is null on a workflow_dispatch run, so the manual redeploy path stays unconditional. `pypi-publish.yaml` is deliberately untouched: PyPI derives "pre-release" from the PEP 440 version alone — an rc tag gives hatch-vcs `0.5.0rc1`, which `pip install` skips without `--pre` — never from the GitHub checkbox. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AujePdgpiCcNnEJ99ruLFu
Contributor
✅ Eval
lc statusConfusion & pain points (Claude analysis)Confusion & pain points
Full trace: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ahead of tagging
v0.5.0rc1:release: publishedfires for pre-releases too (releasedis the type that skips them), so publishing an rc from the GitHub UI would have run— moving the
latestalias onto the rc and making docs.lightconeresearch.org serve rc docs as the site default. That contradicts the workflow's own stated rule that the site tracks the released CLI: PyPI hands an rc only to someone who asks for it by name (--pre, or an exact==0.5.0rc1), so the site must keep serving the last full release.The fix is one
ifon the deploy job.github.event.releaseis null on aworkflow_dispatchrun, so the manual redeploy path stays unconditional.pypi-publish.yamlis deliberately untouched. PyPI has no per-upload pre-release flag — it derives one from the PEP 440 version alone. Verified against this branch's build config: av0.5.0rc1tag gives hatch-vcs0.5.0rc1, whichpip install lightcone-cliskips without--pre. The GitHub checkbox never enters into it.Prose updated in the two places that describe the release flow (
docs/contributing/setup.md,CLAUDE.md).🤖 Generated with Claude Code
https://claude.ai/code/session_01AujePdgpiCcNnEJ99ruLFu