Skip to content

feat(windows): add title-bar navigation strip presentation - #237

Open
LimiNode wants to merge 3 commits into
mainfrom
feat/titlebar-navigation-strip
Open

feat(windows): add title-bar navigation strip presentation#237
LimiNode wants to merge 3 commits into
mainfrom
feat/titlebar-navigation-strip

Conversation

@LimiNode

Copy link
Copy Markdown
Owner

Summary

  • add TitleBarMenuPresentation::{Menu, NavigationStrip} to framed-window config
  • make NavigationStrip flush the in-title-bar menu to the title-region edge
  • use active theme navigation surfaces for selected/hovered/active menu items
  • keep existing title-bar hit-testing, control-button reservation, and drag-region logic
  • document the new presentation mode in English and Russian windowing guides

Validation

  • integrated mgc-platform build: cmake --build build-mingw --target mgc-gui --parallel 36
  • gui_smoke and system_logs_model_smoke passed

The API remains presentation-only: ImGuiX does not know MGC section names or events.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 845eb8274c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +241 to +242
const float menu_start_x = ImMax(cursor_after_title, last_item_right_local) +
(navigation_strip ? 0.0f : style.ItemSpacing.x);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Start an empty navigation strip at the title edge

When NavigationStrip is used with the documented empty drawTitleBarText() slot and default configuration, the caller has already moved the cursor to computeTitleTextLeftInset() before entering this function. Therefore cursor_after_title remains nonzero, and this expression removes only ItemSpacing.x; the strip still starts roughly 2 * WindowPadding.x + width("W") from the title-region edge rather than flush as documented. Account for the empty-title navigation-strip case when computing the starting position.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant