feat(windows): add title-bar navigation strip presentation - #237
feat(windows): add title-bar navigation strip presentation#237LimiNode wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 845eb8274c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const float menu_start_x = ImMax(cursor_after_title, last_item_right_local) + | ||
| (navigation_strip ? 0.0f : style.ItemSpacing.x); |
There was a problem hiding this comment.
Start an empty navigation strip at the title edge
When NavigationStrip is used with the documented empty drawTitleBarText() slot and default configuration, the caller has already moved the cursor to computeTitleTextLeftInset() before entering this function. Therefore cursor_after_title remains nonzero, and this expression removes only ItemSpacing.x; the strip still starts roughly 2 * WindowPadding.x + width("W") from the title-region edge rather than flush as documented. Account for the empty-title navigation-strip case when computing the starting position.
Useful? React with 👍 / 👎.
Summary
TitleBarMenuPresentation::{Menu, NavigationStrip}to framed-window configNavigationStripflush the in-title-bar menu to the title-region edgeValidation
mgc-platformbuild:cmake --build build-mingw --target mgc-gui --parallel 36gui_smokeandsystem_logs_model_smokepassedThe API remains presentation-only: ImGuiX does not know MGC section names or events.