perf: benchmark public macro and logger hot path - #134
Open
LimiNode wants to merge 5 commits into
Open
Conversation
Add a separate public LOGIT_INFO benchmark and a controlled legacy-versus-snapshot registry benchmark. Extract queue/CSV validation into testable helpers, add deterministic negative-path coverage, and strengthen the asynchronous flush test with a delayed sink. Run the new smoke targets in CI and document their measurement contracts.
Track the current TimeShield main commit and update LogIt++ includes to its canonical domain paths. Keep the existing TimeShield API usage and C++11 compatibility while consuming the reorganized formatter and parser headers.
Pin the minimum supported TimeShield version to the v2.0.0 release in build configuration, installed package metadata, and user documentation. The bundled submodule is already pinned to the matching v2.0.0 commit.
Keep the Logger benchmark compatibility path faithful to the pre-optimization stack-vector implementation and preserve white-box test access. Route the delayed flush regression through SpdlogAdapter, make validation checks active in Release, and document the public macro benchmark accurately. Run vcpkg validation against the current pull-request source with TimeShield 2.0.0 instead of combining a historical release port with the new dependency.
Use the compact legacy snapshot correctly when a targeted record selects a non-zero logger index. Add a dedicated two-logger regression test compiled with the legacy benchmark path, and keep the production immutable snapshot indexing unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LOGIT_INFO(...)macro path;v2.0.0release and require TimeShield 2.0.x (minimum 2.0.0).Verification
include_quickstart_testandlogger_hot_path_state_testpassed;Generated build directories and unrelated local files are not included.