File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -24,7 +24,7 @@ struct Message {
2424 ParseSignalsStatus parse_signals (const std::vector<uint8_t >& data, std::vector<double >& values) const ;
2525
2626 void append_signal (const Signal& signal);
27- std::vector<Signal> get_signals () const ;
27+ const std::vector<Signal>& get_signals () const ;
2828 uint32_t id () const ;
2929 uint8_t size () const ;
3030 const std::string& name () const ;
@@ -33,11 +33,11 @@ struct Message {
3333 virtual bool operator ==(const Message& rhs) const ;
3434
3535private:
36- uint32_t m_id;
37- std::string m_name;
38- uint8_t m_size;
39- std::string m_node;
40- std::vector<Signal> m_signals;
36+ uint32_t m_id{} ;
37+ std::string m_name{} ;
38+ uint8_t m_size{} ;
39+ std::string m_node{} ;
40+ std::vector<Signal> m_signals{} ;
4141
4242 friend std::ostream& operator <<(std::ostream& out, const Message& msg);
4343};
Original file line number Diff line number Diff line change @@ -30,7 +30,7 @@ struct Signal {
3030
3131 Signal () = delete ;
3232 virtual ~Signal () = default ;
33- explicit Signal (std::string name,
33+ explicit Signal (const std::string& name,
3434 bool is_multiplexed,
3535 uint32_t start_bit,
3636 uint32_t size,
@@ -40,8 +40,8 @@ struct Signal {
4040 double offset,
4141 double min,
4242 double max,
43- std::string unit,
44- std::vector<std::string> receivers);
43+ const std::string& unit,
44+ const std::vector<std::string>& receivers);
4545
4646 virtual bool operator ==(const Signal& rhs) const ;
4747 bool operator <(const Signal& rhs) const ;
Original file line number Diff line number Diff line change @@ -92,7 +92,7 @@ void Message::append_signal(const Signal& signal) {
9292 m_signals.push_back (signal);
9393}
9494
95- std::vector<Signal> Message::get_signals () const {
95+ const std::vector<Signal>& Message::get_signals () const {
9696 return m_signals;
9797}
9898
Original file line number Diff line number Diff line change 55#include < vector>
66
77namespace Libdbc {
8- Signal::Signal (std::string name,
8+ Signal::Signal (const std::string& name,
99 bool is_multiplexed,
1010 uint32_t start_bit,
1111 uint32_t size,
@@ -15,8 +15,8 @@ Signal::Signal(std::string name,
1515 double offset,
1616 double min,
1717 double max,
18- std::string unit,
19- std::vector<std::string> receivers)
18+ const std::string& unit,
19+ const std::vector<std::string>& receivers)
2020 : name(name)
2121 , is_multiplexed(is_multiplexed)
2222 , start_bit(start_bit)
You can’t perform that action at this time.
0 commit comments