ci: drop the workflows without a subject in this repo - #6
Open
markuslf wants to merge 1 commit into
Open
Conversation
`dependency-review` reviews dependency manifests changed in a pull request. The only manifest here is `.github/pre-commit/requirements.txt`, which Dependabot already watches, so the job runs on every pull request without anything to review. `scorecard` measures the supply-chain posture of a repository others pull in as a dependency. This one ships a stylesheet that gets copied into /usr/share/icingaweb2/modules. Adds a `lessc --lint` hook instead: the theme is a single LESS file that Icinga Web compiles together with its own and every module's LESS, so a parse error takes the whole stylesheet down, not just the theme.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository holds one LESS file, one SVG,
module.infoand three Markdownfiles, and carried six workflows.
Removed:
dependency-review: reviews dependency manifests changed in a pull request.The only manifest here is
.github/pre-commit/requirements.txt, whichDependabot already watches, so the job ran on every pull request with nothing
to review.
scorecard: measures the supply-chain posture of a repository that otherspull in as a dependency. This one ships a stylesheet that gets copied into
/usr/share/icingaweb2/modules.Kept:
codeql: its language matrix isactions, andauto-mergeandpre-commit-autoupdaterun with write permissions and an app token, so theworkflow analysis has a subject. The company standard also asks for code
scanning per repository.
dependabotincluding the pip ecosystem,auto-mergeandpre-commit-autoupdate: together they keep.github/pre-commit/in syncwith the other repositories, where it has to stay byte-identical.
Added a
lessc --linthook. Icinga Web compiles the theme together with itsown and every module's LESS, so a parse error in it takes the whole stylesheet
down, not just the theme. The generic hooks in place so far never looked at the
only source file in the repository.
stylelintwas tried first and dropped: pre-commit installs node packages intoits own environment while stylelint resolves
extendsandcustomSyntaxrelative to the config in the repository, so the LESS syntax never loads and it
fails on the first
//comment.