Skip to content

Shape tracing doesn't display wrappers (OSOE-340) #18

Description

@mvarblow

Thanks for sharing these helpers! The shape tracing helper really filled a need for us. However, one thing I noticed... it doesn't seem to report wrappers. I think the problem is that OrchardCore processes and then clears the wrappers before firing the Displayed event that the shape tracing module hooks into.

Wrappers are cleared here:
https://github.com/OrchardCMS/OrchardCore/blob/1879619df4418ff175a59ba70dcb36bab89fcbb5/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs#L137

But the displayed event is fired just a bit later, here:
https://github.com/OrchardCMS/OrchardCore/blob/1879619df4418ff175a59ba70dcb36bab89fcbb5/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs#L144

Jira issue

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions