Warn at launch on development (dev branch) builds#2439
Open
ps2 wants to merge 2 commits into
Open
Conversation
Present a blocking alert after the status screen appears on each launch when the app was built from the LoopWorkspace dev branch, advising non-testers to switch to main. Detected via BuildDetails.workspaceGitBranch. Gated by a new devBranchWarningEnabled feature flag (on by default, disabled with DEV_BRANCH_WARNING_DISABLED in SWIFT_ACTIVE_COMPILATION_CONDITIONS). The alert offers "I'm a tester" (dismiss) and "Switch to main" (opens the LoopDocs branches page).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devbranch, advising non-testers to switch tomain.BuildDetails.workspaceGitBranch == "dev"(the superproject branch captured intoBuildDetails.plistat build time).devBranchWarningEnabledfeature flag — on by default, disabled by addingDEV_BRANCH_WARNING_DISABLEDtoSWIFT_ACTIVE_COMPILATION_CONDITIONS(e.g. inLoopConfigOverride.xcconfig), matching the existing DIY flag pattern..alert, non-dismissable except by a choice) offers I'm a tester (dismiss) and Switch to main (opens the LoopDocs branches page).LoopAppManager.launchHomeScreen(), alongside the existingAppExpirationAlerterlaunch-alert pattern, so it fires once per launch after onboarding.Test plan
devbuild, the warning appears over the status screen on launch, and again on each subsequent launch.main/release builds (workspaceGitBranch != "dev").DEV_BRANCH_WARNING_DISABLEDto the build's active compilation conditions suppresses the warning.