Tidepool sync 2026-05-11#450
Open
loopkitdev wants to merge 47 commits into
Open
Conversation
- Point all 18 submodule URLs to https://github.com/loopkitdev/* forks - Minizip and TrueTime.swift retain LoopKit origin (no forks) - Add docs/tidepool-sync-2026-03-10.md (Tidepool sync documentation)
…ce docs - Update all 17 submodule commit pointers to reflect rewritten history (filter-branch changed SHAs when fixing author to LoopKit Developer) - Add Loop build fix commit (LoopDataManager init ordering) - Add LOOPKIT_SYNC_PROCESS.md, SYNC_PROGRESS.md, sync-docs/
Catches the superproject up to all submodule work that has accumulated
on tidepool-sync/2026-03-10 since the initial sync commit, including:
- Loop: restore manual dose entry "+" button on insulin delivery screen
- LoopKit, NightscoutService, TidepoolService, LibreTransmitter:
string catalog updates from Xcode build
- OmniKit: fix reentrant lock crash in isSignalLost
- Various submodules: merge upstream/{dev,main} into tidepool-sync branch
Parallel fix to OmniKit 924f10d — OmniBLE had the identical bug where isSignalLost() read state.lastPumpDataReportDate from inside a lockedState.mutate closure, causing recursive lock acquisition.
Tier 1 - LoopKit: bd30c463 (409 commits from tidepool/dev; 18 source conflicts + 19 pbxproj regions resolved; DIY divergence preserved at BasalRateScheduleEditor) - Loop: 76b6b1e3 (14 commits from tidepool/dev; 3 pbxproj regions) Tier 3 - CGM drivers - CGMBLEKit: 69562e7 - G7SensorKit: d024513 - dexcom-share-client-swift: 541de2f - NightscoutRemoteCGM: b1ea9ee - LibreTransmitter: c99daf1 Tier 3 - Pump drivers - RileyLinkKit: 19f5ae8 - OmniKit: b3b6080 (preserves reentrant lock fix; adopts mutateState) - OmniBLE: 645e0fc (preserves reentrant lock fix and Pod Keep Alive suspend special case; adopts mutateState) - MinimedKit: f994d6e (preserves CAGE/IAGE tracking) Tier 3 - Services - TidepoolService: 5f6a064 (incl. DoseEntry dedupe follow-up) - NightscoutService: 1b5cded (preserves APNS response feature) - AmplitudeService: 77dae3e - LogglyService: 8e18081 - MixpanelService: unchanged (already up to date with tidepool) Tier 3 - Support/Onboarding - LoopSupport: a312dfb - LoopOnboarding: fd7e410 Package.resolved - LoopAlgorithm: tidepool-org/LoopAlgorithm bd1a879 (4 test-only commits)
docs/tidepool-sync-2026-05-11.md describes the merge, conflicts, and divergences. SYNC_PROGRESS.md updated to reflect the new branch and the divergences carried forward.
Pulls in 3 small origin/dev updates that landed after this sync started: - Loop: PR #2410 Live activity plot fixes (manual merge to preserve our post-Tidepool-sync API: kept async/await sample fetch + LoopUnit signature, adopted upstream's presetStart<=presetEnd guard and the adjustedChartStart/End helpers) - CGMBLEKit: PR LoopKit#211 handle inactive CGM sensor sessions (clean merge) - OmniBLE: Lokalise translation update (clean merge)
… charts Picks up loopkitdev/Loop@4eea0b24 — widens the carbStatus.dynamicGlucoseEffects sampling window in fetchCarbAbsorptionReview and getHistoricalChartsData from `from: end` to `from: start` so the model-predicted line spans the full chart again (was only generating samples in now+1h … now+7h, outside the visible window). UI-only; no dosing-path impact.
added 3 commits
May 16, 2026 15:11
Picks up loopkitdev/Loop@30725413 — ports Marion's #2399 submodule list into LoopAppManager.generateDiagnosticReport(). The script and BuildDetails plumbing were already in place; only the report consumer was missing after the merges.
Loop submodule changes: - Label manually-entered boluses as External Insulin in the delivery log, with a delete action in the event details screen - Fix Text wrapping in presets training content - Remove the unfinished Performance History entry point from presets Also ignore .claude in the workspace.
…t + pbxproj localization conflicts)
Closed
added 6 commits
May 20, 2026 11:53
Bring in dev's workspace changes (CI workflows, Gemfile, lokalise script, VersionOverride). Submodule gitlinks kept at the tidepool-sync/2026-05-11 tips (the unmerged sync branches), to be re-bumped as submodule PRs land.
Contributor
TestI have been testing this from the loopkitdev repository over the last few weeks.
ConfigurationMost recent test is with LoopWorkspace commit 68ce294. This is behind but still valid for the items I tested. Phone is SE 3rd gen running iOS 26.5. Review prior issues with 213Referring to the table in PR #213 which listed issues with the previous PR. There were 10 items.
Edited to update Item 1: there was a message about invalid Siri Support - Localized description for a few phrases in my email from Apple. Note about preset changeThe presets affects active insulin during the preset duration - not throughout the duration of the insulin lifetime. When you choose a preset that has 170% insulin needs or greater, the new code adds a new safety limit. Instead of using your glucose safety limit and your target range, it limits the lower bound to be 110 mg/dL. See this table. Notice that the recommended dose for a fixed carb entry of 50 g for insulin needs of 200% is less than 150% because the modified minimum threshold (from 70 mg/dL to 110 mg/dL). All other settings used glucose safety of 70 mg/dL. The target thresholds for all value are the same (110-120 mg/dL).
|
added 8 commits
May 20, 2026 20:17
Document that upgrading dev→sync migrates the shared store to Modelv6 and cannot be reverted: dev ships only up to Modelv4 and can't open a v6 store, so reverting leaves the app unable to load its data store (no on-disk data loss, but dev needs a delete+reinstall, rebuilding from HealthKit). Also records that the forward migration now preserves dose amounts (value→deliveredUnits). Includes the earlier 2026-03-10 LoopAlgorithm-packaging callout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshed Tidepool → DIY sync for the whole workspace, from the
tidepool-sync/2026-05-11branch. Supersedes and replaces the previous Tidepool merge PR (#213).See Tidepool → LoopKit DIY Sync — 2026-03-10 and Tidepool → LoopKit DIY Sync — 2026-05-11 for more details
Submodule gitlinks currently point at the unmerged per-repo
tidepool-sync/2026-05-11branches. They will be updated to the merged commits as each submodule PR below lands.Submodule PRs
Notes
devwas merged into the Loop sync branch to resolve conflicts (WatchAppInfo.plistLive Activity launch keys +project.pbxprojlocalization file references). Loop builds clean.