Alpha support#762
Merged
Merged
Conversation
…er (helps when using transparent pills)
carroarmato0
added a commit
to carroarmato0/NextUI
that referenced
this pull request
Jul 4, 2026
Brings in the maintainer's "Alpha support" feature (upstream PR LoveRetro#762): theme colours are now packed RGBA (8-digit hex, opaque-alpha upgrade for legacy RGB), new *_RECT assets, alpha-aware GFX blit paths, and a configurable game-switcher curtain overlay (CFG_getGameSwitcherCurtain + GFX_blitTop/BottomCurtain). Most of it auto-merged cleanly -- the feature lands mainly in api.c/config.c (which we kept as C) and the settings color picker, largely outside our refactor surface. Two conflicts, both the same shape and resolved by taking upstream's alpha logic while keeping our C++20 encapsulation: - settings/colorpickermenu.cpp -- adopt the new alpha channel (R/G/B/A width measure, "#RRGGBBAA" 8-digit hex) but route font access through GFX_getFonts() instead of the now-private `font` global. - settings/menu.cpp -- same: upstream's 0x%08X RGBA label, our GFX_getFonts(). The one migration-caused touch the evaluation predicted (a `font.small` ref in the new color-picker code) fell out of the colorpickermenu conflict. No compound-literal patterns in the new code, so the g++ codegen landmine is not a factor. Left the new config.c sprintf(value,...) serialization as-is: it matches config.c's existing convention and CFG_get has no buffer-size param. All of tg5040 builds clean (nextui, minarch, settings).
carroarmato0
pushed a commit
to carroarmato0/NextUI
that referenced
this pull request
Jul 5, 2026
…oveRetro#762) * feat: full alpha transparency support for theme colors, 3-slicing for pill sprites * feat: option for a half-transparent top/bottom curtain on game switcher (helps when using transparent pills)
carroarmato0
added a commit
to carroarmato0/NextUI
that referenced
this pull request
Jul 5, 2026
Brings in the maintainer's "Alpha support" feature (upstream PR LoveRetro#762): theme colours are now packed RGBA (8-digit hex, opaque-alpha upgrade for legacy RGB), new *_RECT assets, alpha-aware GFX blit paths, and a configurable game-switcher curtain overlay (CFG_getGameSwitcherCurtain + GFX_blitTop/BottomCurtain). Most of it auto-merged cleanly -- the feature lands mainly in api.c/config.c (which we kept as C) and the settings color picker, largely outside our refactor surface. Two conflicts, both the same shape and resolved by taking upstream's alpha logic while keeping our C++20 encapsulation: - settings/colorpickermenu.cpp -- adopt the new alpha channel (R/G/B/A width measure, "#RRGGBBAA" 8-digit hex) but route font access through GFX_getFonts() instead of the now-private `font` global. - settings/menu.cpp -- same: upstream's 0x%08X RGBA label, our GFX_getFonts(). The one migration-caused touch the evaluation predicted (a `font.small` ref in the new color-picker code) fell out of the colorpickermenu conflict. No compound-literal patterns in the new code, so the g++ codegen landmine is not a factor. Left the new config.c sprintf(value,...) serialization as-is: it matches config.c's existing convention and CFG_get has no buffer-size param. All of tg5040 builds clean (nextui, minarch, settings).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.