feat(pipeline): add when: conditional task execution#83
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1e96614 to
79479dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional
when:field to pipeline tasks. When present, the runner evaluates the condition before executing the task — if the condition is false the task is skipped (a notice is printed, no error is thrown). This enables parameter-driven pipelines where certain tasks are optional, e.g. upload only when--param upload=trueis passed.Three expression forms are supported:
${name}tokens are resolved from parameters (highest priority), then task env, then pipeline env. Unknown tokens resolve to""(falsy). Falsy values:"false","0","no", empty string.Dry-run output shows the condition and its evaluated outcome:
The pipeline summary counts only executed tasks (skipped tasks excluded).
Builds on the pipeline parameters feature (PR #82 —
--param KEY=VALUEsupport).Type of Change
How Has This Been Tested?
New test file:
Tests/Core/TaskConditionEvaluatorTests.swift— 20 tests covering equality, inequality, presence, substitution, unknown tokens, whitespace trimming, malformed expressionsExtended existing tests:
PipelineRunnerTests— 4 new tests: passing condition executes, failing condition skips, mixed skip/execute, nilwhenalways executesPipelineLoaderTests—when:field decoded from YAML fixtureChecklist
Breaking Changes?
Additional Notes
TaskConditionEvaluatoris a new standalone component following the protocol-oriented DI pattern.PipelineRunnerreceives it via an internal init for test injection; the publicinit(printer:)uses the default implementation.