feat(cli): global --spec lookup checks all spec file names in priority order#86
Merged
Merged
Conversation
…nder Rename InstallCommandError.globalLucafileMissing to globalSpecMissing and extract the global spec lookup logic from InstallCommand into a new GlobalSpecFinder component in LucaCore, making it fully testable via GlobalSpecFinderTests.
… conformance lists
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
luca install --globalis run without an explicit--spec, the command previously hardcoded a lookup for~/.config/luca/Lucafileonly. It now iterates all recognised spec file names (Lucafile,Toolfile,Skillfile— and their.ymlvariants) in priority order, returning the first match found.specPath()behaviour for CWD lookups.GlobalSpecFindercomponent inLucaCore.Type of Change
How Has This Been Tested?
GlobalSpecFinderTestscovering all spec file names,.ymlvariants, priority order, and thenoSpecFounderrorswift run luca install --helpconfirms updated--globalflag descriptionChecklist
Breaking Changes?
Additional Notes
GlobalSpecFinderis a newLucaCorecomponent following the project's protocol-oriented DI pattern (GlobalSpecFindingprotocol +GlobalSpecFinderFileManagingfile system protocol).InstallCommand.globalSpecPath()delegates to it and translates the error intoInstallCommandError.globalSpecMissing.