feat: split LucaCore into sub-targets and introduce LucaFoundation#87
Merged
albertodebortoli merged 2 commits intoMay 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
albertodebortoli
force-pushed
the
worktree-feature+pipeline-manager-targets
branch
from
d7baf9e to
3c3c33d
Compare
- PipelineCore: pipeline/run command logic (Pipeline* models, PipelineLoader, PipelineRunner, PipelineValidator, ParameterResolver, TaskConditionEvaluator) - ManagerCore: install/manage tools and skills (Installer, ToolInstaller, SkillInstaller, Downloader, ArchitectureValidator, BinaryFinder, SelfUpdater, and all related components) - LucaCore: shared foundation (Spec, Tool, Skill, ChecksumAlgorithm, Printer, SpecLoader, SpecFinder, SpecInitializer, SubprocessRunner) - SubprocessRunner made public and moved to LucaCore as shared utility - FileManaging moved to ManagerCore; PipelineValidatorFileManaging stays in PipelineCore and FileManagerWrapper conforms to it directly - All 481 tests pass
albertodebortoli
force-pushed
the
worktree-feature+pipeline-manager-targets
branch
from
3c3c33d to
7acf8b8
Compare
Rename the original LucaCore to LucaFoundation (shared primitives: models, protocols, SpecLoader, SubprocessRunner, Printer, Constants). Introduce a new LucaCore umbrella that re-exports LucaFoundation, PipelineCore, and ManagerCore via @_exported import, so LucaCLI and tests only need a single import LucaCore. Move SpecFinder and SpecInitializer into the new LucaCore since they are only consumed by CLI commands, not by ManagerCore internals.
albertodebortoli
force-pushed
the
worktree-feature+pipeline-manager-targets
branch
2 times, most recently
from
69b33ad to
8c1c5b8
Compare
albertodebortoli
added
refactoring
albertodebortoli
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reorganises the Swift package into a cleaner multi-target hierarchy:
Spec,Tool,Skill,ChecksumAlgorithm), protocols (SpecLoading,SubprocessRunning,Printing), and utilities (SpecLoader,SubprocessRunner,Printer,Constants).runcommand (pipeline loading, running, validation, parameter resolution).LucaFoundation,PipelineCore, andManagerCorevia@_exported importsoLucaCLIand tests only need a singleimport LucaCore.SpecFinderandSpecInitializerlive in the newLucaCoresince they are only consumed by CLI commands, not byManagerCoreinternals.No breaking changes to external consumers —
LucaCorestill exports everything.Type of Change
How Has This Been Tested?
swift buildpasses locallyswift testpasses locally — 481 tests, all passingChecklist
Breaking Changes?
Additional Notes
The
@_exported importpattern on the umbrellaLucaCoremeans all consumers continue to use a singleimport LucaCorewithout change. Internally,PipelineCoreandManagerCoreboth importLucaFoundation.