fix(harness): pass LUCE_SERVER_BIN in the omp launcher test - #762
Merged
Merged
Conversation
#603 added test_run_omp_config.sh before the dflash -> luce engine rename and merged main without textual conflict, so the test still set DFLASH_SERVER_BIN. common.sh now reads LUCE_SERVER_BIN, ignored the fake server and fell back to $REPO_DIR/server/build/luce_server, which does not exist, failing server_unit_omp_harness_config on main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
Build (cmake + uv sync --extra megakernel)job on main (run 35985420610):server_unit_omp_harness_configfailed withluce_server not found or not executable.Cause: #603 added
harness/tests/test_run_omp_config.shbefore the dflash -> luce engine rename (88d3340) and merged main without a textual conflict. The test still setDFLASH_SERVER_BIN, butharness/clients/common.shnow readsLUCE_SERVER_BIN, so it ignored the fake server and fell back to$REPO_DIR/server/build/luce_server, which the test's fake repo doesn't have.Fix: set
LUCE_SERVER_BINand rename the fake binary toluce_server, matching the pi and client-timeout tests.Test:
bash harness/tests/test_run_omp_config.sh harness/clients/run_omp.sh->OMP launcher configuration: PASS🤖 Generated with Claude Code