⚡ Bolt: [performance improvement] Avoid clone via surface_count and iter_surfaces - #403
⚡ Bolt: [performance improvement] Avoid clone via surface_count and iter_surfaces#403Lucenx9 wants to merge 1 commit into
Conversation
Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What: Added
iter_surfacesandsurface_countmethods toWorkspaceModelto avoid allocatingVec<Surface>when counting or iterating over surfaces. Replaced.list_surfaces(...).len()and.list_surfaces(...).iter()with these new methods.🎯 Why: The
list_surfacesmethod clones all matched surfaces into a new Vector. In many call sites, we only need the count, or we only want to iterate over the items without mutating them, making the Vector allocation and struct cloning completely redundant.📊 Impact: Reduces heap allocations directly correlated to the number of surfaces present in the workspace, particularly improving performance during updates affecting surface trees.
🔬 Measurement: Review memory profiling during surface operations or monitor the number of
Vecallocations during heavy workspace load.PR created automatically by Jules for task 15563467038579687858 started by @Lucenx9