Skip to content

⚡ Bolt: [performance improvement] Avoid clone via surface_count and iter_surfaces - #403

Open
Lucenx9 wants to merge 1 commit into
mainfrom
bolt-opt-surface-count-15563467038579687858
Open

⚡ Bolt: [performance improvement] Avoid clone via surface_count and iter_surfaces#403
Lucenx9 wants to merge 1 commit into
mainfrom
bolt-opt-surface-count-15563467038579687858

Conversation

@Lucenx9

@Lucenx9 Lucenx9 commented Aug 17, 2026

Copy link
Copy Markdown
Owner

💡 What: Added iter_surfaces and surface_count methods to WorkspaceModel to avoid allocating Vec<Surface> when counting or iterating over surfaces. Replaced .list_surfaces(...).len() and .list_surfaces(...).iter() with these new methods.
🎯 Why: The list_surfaces method clones all matched surfaces into a new Vector. In many call sites, we only need the count, or we only want to iterate over the items without mutating them, making the Vector allocation and struct cloning completely redundant.
📊 Impact: Reduces heap allocations directly correlated to the number of surfaces present in the workspace, particularly improving performance during updates affecting surface trees.
🔬 Measurement: Review memory profiling during surface operations or monitor the number of Vec allocations during heavy workspace load.


PR created automatically by Jules for task 15563467038579687858 started by @Lucenx9

Co-authored-by: Lucenx9 <185146821+Lucenx9@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 36dd2a65-0e3f-427a-af06-f1efc951ea57


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant