Pin release workflows to pnpm 9 (lockfile v9) - #3
Merged
Conversation
Both release workflows still installed pnpm 8, which cannot read the lockfileVersion 9.0 pnpm-lock.yaml -- it would silently ignore the lockfile and install unpinned latest dependencies during release builds. Same fix ci.yml already received. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mohnjiles
enabled auto-merge
July 25, 2026 04:18
ionite34
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlandupdate-json.ymlstill install pnpm 8, which cannot read the currentlockfileVersion: 9.0lockfile — pnpm 8 ignores it with a warning and performs an unpinned install, so release builds would run against unvetted latest dependencies. Pin both to pnpm 9 viapnpm/action-setup@v4, matching the fixci.ymlreceived in #2.Test plan
v*tag build🤖 Generated with Claude Code