Vendor OpenSSL on macOS (x86_64 cross-compile fix) - #6
Merged
Conversation
GitHub macos-latest runners are ARM, so the x86_64-apple-darwin release build is a cross-compile and openssl-sys (via curl-sys) fails: pkg-config refuses to provide the host ARM OpenSSL for a foreign target. Build OpenSSL from source on macOS instead, scoped so the Linux build keeps linking the system library as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
mohnjiles
enabled auto-merge
July 25, 2026 05:43
ionite34
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second macOS release failure, different cause: the heap fix worked (frontend built), but the x86_64-apple-darwin job then failed compiling
openssl-syswith$HOST = aarch64-apple-darwin / $TARGET = x86_64-apple-darwin—macos-latestrunners are ARM Macs, so the Intel build is a cross-compile, and pkg-config will not serve the host ARM OpenSSL for a foreign target. (curl → curl-sys → openssl-sysis the dependency path; openssl-sys is not in the Windows graph at all.)Fix: vendored OpenSSL on macOS only (
[target.'cfg(target_os = "macos")'] openssl-sys = { features = ["vendored"] }) — openssl-sys builds OpenSSL from source for whichever target is being compiled. Linux keeps linking system OpenSSL unchanged; adds a few minutes to the mac jobs.Test plan
cargo checkstill clean on Windows;openssl-srcresolved into Cargo.lock🤖 Generated with Claude Code