USE 531 - Refactor data types into folder#188
Merged
Conversation
Why these changes are being introduced: With a new data type "fulltexts" coming online soon, and the refactoring of "records" and "embeddings" into equal footing data types, it felt like a good time to establish a dedicated space for data type definitions. How this addresses that need: Adds new `data_types/` folder. Records and Emmbeddings moved here, and Fulltexts will live here soon. Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/USE-531
ghukill
force-pushed
the
USE-531-fulltext-data-type
branch
from
879b8ae to
2909b44
Compare
jonavellecuerdo
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
Small PR to refactor
records.pyandembeddings.pyinto newdata_types/folder:Allows for imports like:
With a new data type "fulltexts" coming online soon, and the refactoring of "records" and "embeddings" into equal footing data types, it felt like a good time to establish a dedicated space for data type definitions.
How can a reviewer manually see the effects of these changes?
make test+make lintshould be sufficient; just modification of imports.Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review