Skip to content

feat(ci): parameterize reusable workflow runners#154

Merged
vatsalyagoel merged 7 commits into
mainfrom
feat/parameterize-workflow-runners
May 21, 2026
Merged

feat(ci): parameterize reusable workflow runners#154
vatsalyagoel merged 7 commits into
mainfrom
feat/parameterize-workflow-runners

Conversation

@vatsalyagoel
Copy link
Copy Markdown
Contributor

@vatsalyagoel vatsalyagoel commented May 21, 2026

Adds an optional runs-on input to reusable GitHub Actions workflows so callers can override the job runner instead of being locked to ubuntu-latest.

  • Preserve existing behavior by defaulting runs-on to ubuntu-latest
  • Update Node, Python, Zendesk, publishing, deployment, and SHA-pinning reusable workflows to use the runs-on input
  • Keep event-only workflows on their existing hard-coded runners
  • Use an explicit ubuntu-latest fallback in the mixed-trigger SHA-pinning workflow for push/PR runs

Validation:

  • Parsed all workflow YAML files successfully
  • LSP diagnostics reported 0 errors for .github/workflows
  • Confirmed actionlint is not installed locally, so that check could not be run

Breaking changes: none expected for existing callers.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

🛡️ SHA Pinned Actions Report

✅ All 28 file(s) passed — actions are allowed and pinned as required.

ensure-sha-pinned:
name: Ensure SHA Pinned Actions
runs-on: ubuntu-latest
runs-on: ${{ inputs.runner || 'ubuntu-latest' }}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about why this one has a default value, i.e. || 'ubuntu-latest' and the other ones don't.

Comment on lines +15 to +18
runner:
required: false
type: string
default: ubuntu-latest
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about using runs-on so it's hopefully clearer to consumers what it is given it's the default terminology?

@vatsalyagoel vatsalyagoel merged commit 9cccf7a into main May 21, 2026
1 check passed
@vatsalyagoel vatsalyagoel deleted the feat/parameterize-workflow-runners branch May 21, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants