SARIF short titles by filling tool.driver.rules and CVSS score - #75
Open
dancewithheart wants to merge 10 commits into
Open
SARIF short titles by filling tool.driver.rules and CVSS score#75dancewithheart wants to merge 10 commits into
tool.driver.rules and CVSS score#75dancewithheart wants to merge 10 commits into
Conversation
* improvement in file locations * replace single global SARIF location with one location per result: - compute (sarifLocation, sarifRegion) per advisory result - use concernedInfo package names to choose the location
dancewithheart
marked this pull request as ready for review
April 22, 2026 16:42
This was referenced Apr 22, 2026
dancewithheart
marked this pull request as draft
May 21, 2026 11:59
add tests for matching file and location, regen nix after adding seri dependency ignore comments and choose full words match drop TODOs that are handled and fix spellings in tests ignore empty keywords, drop isHorizontalSpace, one isBoundry instead of isLeftBoundary and isRightBoundary refactor replace String => Text, extract findCabalFiles refactor drop duplication for finding cabal/freeze files in chooseSarifLocation and chooseSarifLocationForPackages refactor do not read and check existance of cabal files refactor findMap
drop unused test dependency
dancewithheart
force-pushed
the
sarif-github-code-scanning
branch
from
May 30, 2026 17:42
ae23f99 to
e1661c8
Compare
tool.driver.rules and CVSS score
dancewithheart
force-pushed
the
sarif-github-code-scanning
branch
from
May 30, 2026 19:46
1e5802b to
e1dc803
Compare
dancewithheart
marked this pull request as ready for review
May 31, 2026 22:08
This was referenced Jun 1, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in SARIF
properties.tagsSARIF support for code scanning states that:
properties.security-severity(recently improved in add CVSS 3.1 temporalMetrics and environmentalMetrics haskell/security-advisories#322 and Support missing features CVSS V4 haskell/security-advisories#327))this is why there is
securityintagsbefore:
"properties": {}now they are emitted:
I tested on Github code scanning UI properly render by severity and allow filtering using tags.
tool.driver.rulesthat allows GitHub code scanning to show concise alert titlesbefore
after:
This fixes blackheaven/haskell-security-action#2
Pictures before and after rendering on Github: blackheaven/haskell-security-action#2 (comment)