Fix settings icon looking like a brightness/sun icon - #24
Merged
Conversation
The settings (ตั้งค่า) button used a circle-with-radial-spokes SVG that read as a sun/brightness icon — nearly identical to the light-theme sun on the adjacent ThemeToggle. Replace it with a proper gear/cog icon so it clearly reads as settings.
The post-drill chart plotted WPM on the y-axis and seconds on the x-axis but neither axis was labelled, so the y-values read ambiguously. Add 'WPM' and 'วินาที' axis titles, widen the padding to fit them, and style the label text against our tokens (LayerChart's default label classes rely on svelte-ux utilities absent here).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings (ตั้งค่า) button used a circle-with-radial-spokes SVG that
read as a sun/brightness icon — nearly identical to the light-theme sun on
the adjacent ThemeToggle. Replace it with a proper gear/cog icon so it
clearly reads as settings.