feat(flow-view): show span info on the trace flow edges#243
Merged
Conversation
Trace flow diagram edges were bare smoothstep lines. Each edge now carries a FlowEdgeData payload (duration/min/max, trace share, start offset from parent, x-count, error/missing flags, category accent) and renders through a custom edge component: - default labels only on significant edges (errors, >=5% of trace, combined xN groups) to keep dense traces readable - hover reveals the full pill: +offset -> duration (share), with min-max range for combined groups and "no data" for missing spans - stroke width scales with trace share (same sqrt curve as the card cost rail); error edges red, missing-span edges dashed/unanimated - stroke color moved from a hardcoded dark oklch to a theme token Flow-lab spans get staggered start times so the offset path is exercised in the sandbox. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Your Pullfrog Router balance is exhausted. You have a card on file but auto-reload is disabled, so runs paused once your balance went past the overdraft buffer. Top up balance → · Enable auto-reload →
|
PR #242 pinned creator roles onto MCP keys and added tests asserting a member key cannot create standard keys or revoke other users' keys, but the authorization layers still stamped every resolved API key with the default (root) roles, so those restrictions never applied and the tests fail on main (200 instead of 403). Plumb resolved.roles through the v1 and v2 authorization layers and the MCP tenant resolver, falling back to the defaults for keys without pinned roles. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Trace Flow view edges were bare smoothstep lines. Each edge now carries a
FlowEdgeDatapayload and renders through a new custom edge component (packages/ui/src/components/traces/flow-edge.tsx):×Ngroups (×3 · 51.0ms), and edges consuming ≥5% of the trace. Fast internal hops stay as clean lines so dense traces remain readable.+120.0ms → 210.0ms (44%): start offset from the parent span (tinted with the target's category accent), total duration, and share of the trace. Combined groups append· ×3, 13.0ms–21.0ms(min–max); missing-span edges show no data.oklchedge stroke is replaced with a theme token (var(--flow-edge, var(--border))).Why
The flow card redesign (icon chips + cost rail) made the nodes information-dense, but the paths between them carried nothing. Timing, fan-in counts, and error state on the edges make the flow diagram answer "where did the time go" without opening the detail panel.
Notes for review
packages/ui(the flow view is shared with the local-mode UI and landing).pointer-events-noneand hover is driven by a 16px invisible hit path, so node clicks and pan gestures are unaffected (verified in/flow-lab).+0ms./flow-lab(all card/edge variants, hover states, error + missing-span edges, click-through selection) and repo typecheck passes. No existing tests cover flow-utils.🤖 Generated with Claude Code
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.