Skip to content

feat(settings): redesign Ingestion page to Paper spec#251

Merged
Makisuo merged 2 commits into
mainfrom
feat/ingestion-settings-redesign
Jul 22, 2026
Merged

feat(settings): redesign Ingestion page to Paper spec#251
Makisuo merged 2 commits into
mainfrom
feat/ingestion-settings-redesign

Conversation

@Makisuo

@Makisuo Makisuo commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

What

Rebuilds Settings → Ingestion to match the Paper design ("Settings — Ingestion (redesign)" artboard in the "Maple MCP" file), aligning it with the recently redesigned API Keys page (bordered lists, mono micro-labels, hover-reveal actions).

  • Status banner — live ingest health at the top: green dot + N services · X spans/min when receiving (with an Explore traces link), amber pulse while waiting. Send test event shows only when telemetry isn't set up yet. useIngestConnection now exposes spansPerMinute (1h service-overview span counts ÷ 60). The design's "last event Xs ago" was dropped — no data source for it.
  • Endpoint & keys — the two side-by-side cards merged into one card with lane-aligned rows: label | mono HTTP/CLIENT/SERVER badge | value + description | reveal/copy/regenerate actions, plus a Docs ↗ header link. Values are click-to-copy with inline check feedback (masked keys copy the full value without revealing).
  • Send your first telemetry — framework picker rendered as compact pills in the section header; Install / Instrument / Claude Code tabs sit flush in the card. guided-setup.tsx now exports useGuidedFramework(), FrameworkPicker (compact), and ConnectInstructions (variant="flush"); the dashboard checklist's GuidedSetup is unchanged.
  • Recommendations — bordered-list rows with mono uppercase kind tags (RENAME/DUPLICATE/NAMING), always-visible Apply fix / Dismiss / Reopen, and Open · N / Closed · N segmented pills. Detail-page links kept.
  • Attribute mappings — 4-lane table (NAME | RULE | OPERATION | CONTEXT) with mono column headers; keeps the enable Switch, hover edit/delete, and the add/edit + delete dialogs.

Why

The old page was a stack of mismatched Cards; this brings it in line with the design system used by the API Keys redesign and the rest of the settings surface.

Notes for review

  • Presentation-only: no API/domain/backend changes, all existing atoms/mutations reused.
  • Verified live at /settings?tab=ingestion (dev login): key reveal/click-to-copy, chip + tab switching with URL/key interpolation, Open/Closed recommendation tabs, add-mapping dialog, both banner states. bun typecheck passes.

🤖 Generated with Claude Code


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

Rebuild Settings → Ingestion to match the "Settings — Ingestion
(redesign)" artboard (Paper "Maple MCP" file):

- Live status banner: green dot + "N services · X spans/min" when
  receiving (Explore traces link), amber pulse + "Send test event"
  only while waiting for first telemetry. useIngestConnection now
  exposes spansPerMinute from the 1h service overview.
- Single "Endpoint & keys" card with lane-aligned rows (HTTP/CLIENT/
  SERVER mono badges), Docs link, and click-to-copy values with
  inline check feedback alongside the reveal/copy/regenerate actions.
- "Send your first telemetry": compact framework pill chips in the
  section header + flush Install/Instrument/Claude Code tabs
  (guided-setup now exports useGuidedFramework, FrameworkPicker
  compact variant, ConnectInstructions flush variant; dashboard
  checklist unchanged).
- Recommendations: bordered-list rows with mono kind tags and
  always-visible Apply fix / Dismiss / Reopen; Open/Closed pills.
- Attribute mappings: NAME | RULE | OPERATION | CONTEXT lanes with
  mono column headers; keeps Switch, hover edit/delete, and dialogs.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@pullfrog

pullfrog Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Your Pullfrog Router balance is exhausted.

You have a card on file but auto-reload is disabled, so runs paused once your balance went past the overdraft buffer.

Top up balance → · Enable auto-reload →

Pullfrog  | ⚠️ this action is pinned to a commit SHA, which freezes the cleanup step — switch to @v0 or keep the SHA fresh with Dependabot | Rerun failed job ➔View workflow run | via Pullfrog | Using Claude Opus𝕏

@maple/domain#typecheck raced @maple-dev/clickhouse-builder:build on
cold caches — the builder is dist-based (types resolve from dist/), so
consumers' typecheck failed with TS2307 module-not-found whenever it
started before the builder finished building. Make typecheck depend on
^build so dist-based deps exist before consumers typecheck.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@Makisuo
Makisuo merged commit c358e13 into main Jul 22, 2026
7 of 8 checks passed
@Makisuo
Makisuo deleted the feat/ingestion-settings-redesign branch July 22, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant