Tags filtering - #12
Conversation
gpetretto
left a comment
gpetretto
left a comment
There was a problem hiding this comment.
Thanks for implementing this. I tested and left a few comments, more related to the functionalities than to the implementation.
| hiddenTagCount() { | ||
| return Math.max(this.tags.length - this.visibleTags.length, 0); | ||
| }, | ||
| hiddenTagsHoverText() { |
There was a problem hiding this comment.
Is this hover really needed? it remains in the way when clicking on the +N and it does not seem very informative
There was a problem hiding this comment.
true, I was also annoyed by it ... I only added it because files and blocks had it too. I've modified TagList.vue so that the hover disappears when you click.
| }, | ||
| TagList: { | ||
| tags: "tags", | ||
| maxVisible: { value: 2 }, |
There was a problem hiding this comment.
I don't expect it to be trivial, but I wonder if this value could vary depending on the width of the column?
There was a problem hiding this comment.
It could but I'd keep just 2. It can also vary depending on the size of the tags actually.... Worst case is that the line gets "2 lines". I took 2 as a reasonable amount somehow.
There was a problem hiding this comment.
This is what can happen for example
| }); | ||
| } | ||
| }); | ||
|
|
There was a problem hiding this comment.
Is this the correct approach? If many free-text tags the list could be very long. Also, I wonder if with many items building this list may be time consuming. What if this list is only for the defined tags and a free text field for the free text tags?
There was a problem hiding this comment.
Ok following our discussion, I've put managed tags first, free text tags are hidden initially with a possibility to show them + when you search, it searches the full list. Also added "show free text tags / hide free text tags"
DianaAliabieva
left a comment
DianaAliabieva
left a comment
There was a problem hiding this comment.
hello
for me this pr is clear, only the thing that i send you by teams that we discussed already a bit.
3 participants
No description provided.