Skip to content

User entitie - #1

Open
PedroOSanches wants to merge 12 commits into
devfrom
user-entitie
Open

User entitie#1
PedroOSanches wants to merge 12 commits into
devfrom
user-entitie

Conversation

@PedroOSanches

Copy link
Copy Markdown

No description provided.

@lseixas lseixas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PedroOSanches reverte as alterações que você fez nas rotas, não vamos usa-las do jeito que estão agora

Deixa alterações apenas nos arquivos: user.py, test_user.py, user_repo_mock.py, test_user_repo_mock.py, user_repository_interface.py

Comment thread src/shared/infra/repositories/user_repository_mock.py Outdated
Comment thread src/shared/infra/repositories/user_repository_mock.py Outdated
Comment thread src/shared/infra/repositories/user_repository_mock.py Outdated
Comment thread requirements-dev.txt
Comment thread src/shared/infra/repositories/user_repository_mock.py Outdated
Comment on lines +41 to +58
def update_user(
self,
user: User,
new_password_hash: str | None = None,
new_user_role: ROLE | None = None
) -> User:

if new_password_hash is None and new_user_role is None:
raise MissingParameters("At least one parameter must be provided for update.")

for stored_user in self.users:
if stored_user.user_id == user.user_id:
if new_password_hash is not None:
stored_user.password_hash = new_password_hash

if new_user_role is not None:
stored_user.role = new_user_role
return stored_user

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta quase certo pedro,

a ideia desse método vai ser receber apenas a entidade User e atualizar ela "por inteiro"

tipo vai ficar na assinatura do método apenas def update_user(self, user: User): - ai dentro do método você encontra o usuário a ser atualizado usando user.user_id e faz um self.users[idx] = user, sobrescrevendo o usuário do banco com um "novo" usuário que na verdade traz os campos atualizados

pensa que o user do banco vai estar assim User("id", "camila@gmail", "User", "senha_1"). Esse método vai sobrescrever com a nova entidade (que vai ter os mesmos campos inalterados E os campos alterados também) User("id", "camilda@gmail.com", "User", "senha_2")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants