Feature/workflow ocr pipeline/jiahao - #32
Open
down-street wants to merge 5 commits into
Open
Conversation
Collaborator
Author
|
Linting passed for the first commit. |
Owner
|
PR Merging checklist: The person doing the PR
For the reviewer:
|
Owner
|
I think there is some problem with the git submodule in this PR? the pipeline is failing |
McLavish
requested changes
Dec 14, 2025
McLavish
left a comment
McLavish
left a comment
Owner
There was a problem hiding this comment.
- Benchmarking data is missing
- Workflow does not use the GPU courtesy of @Russellpang
Owner
There was a problem hiding this comment.
I don't understand what is this fixing exactly?
Owner
There was a problem hiding this comment.
the benchmarking data is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add a flake ignore to avoid confliction