intergrate app-level profiling into sebs.py - #33
Open
down-street wants to merge 2 commits into
Open
Conversation
Owner
|
Is @Russellpang also working on this? |
Owner
|
PR Merging checklist: The person doing the PR
For the reviewer:
|
McLavish
requested changes
Dec 14, 2025
McLavish
left a comment
Owner
There was a problem hiding this comment.
experiments should be under sebs/experiments. You have placed it under experiment/gpu_app_metrics.py
McLavish
requested changes
Dec 14, 2025
Owner
There was a problem hiding this comment.
I don't think this is how you extend sebs to include new experiments. You would have to add a new experiment type under sebs/experiments/init.py and then define the experiment in there
Owner
|
for the record I've tried running it and it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
running script: python sebs.py experiment gpu-app-metrics --config config/local_deployment.json --deployment local --cache cache --output-dir output/gpu_app_metrics_run1 --update-code --update-storage --verbose --language-version=3.11