Skip to content

intergrate app-level profiling into sebs.py - #33

Open
down-street wants to merge 2 commits into
developmentfrom
feature/plot_intergrate/jiahao
Open

intergrate app-level profiling into sebs.py#33
down-street wants to merge 2 commits into
developmentfrom
feature/plot_intergrate/jiahao

Conversation

@down-street

Copy link
Copy Markdown
Collaborator

running script: python sebs.py experiment gpu-app-metrics --config config/local_deployment.json --deployment local --cache cache --output-dir output/gpu_app_metrics_run1 --update-code --update-storage --verbose --language-version=3.11

@McLavish

McLavish commented Dec 9, 2025

Copy link
Copy Markdown
Owner

Is @Russellpang also working on this?

@McLavish

McLavish commented Dec 10, 2025

Copy link
Copy Markdown
Owner

PR Merging checklist:

The person doing the PR

  • I have tested all the benchmarks and they run locally
  • I have deleted the cache folder and re-run the benchmarks
  • I have tested my benchmarks on another machine

For the reviewer:

  • I have checked the changed files
  • I have run the benchmarks on my machine

@McLavish McLavish added this to the final meeting milestone Dec 10, 2025

@McLavish McLavish left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

experiments should be under sebs/experiments. You have placed it under experiment/gpu_app_metrics.py

Comment thread sebs.py

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is how you extend sebs to include new experiments. You would have to add a new experiment type under sebs/experiments/init.py and then define the experiment in there

@McLavish

Copy link
Copy Markdown
Owner

for the record I've tried running it and it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants