DummyLoader: Skip registering the interfaces as part of the loader#177
Draft
forderud wants to merge 3 commits into
Draft
DummyLoader: Skip registering the interfaces as part of the loader#177forderud wants to merge 3 commits into
forderud wants to merge 3 commits into
Conversation
ad7b33d to
257a608
Compare
…e loader Done to prevent the loader from "hijacking" the registration of the IImage3dSource and IImage3dFileLoader interfaces that should really be the responsibility of the "host" SW to register.
…d of the loader. This depends on Image3dAPI.tlb being found in the system PATH.
257a608 to
760a558
Compare
jogerh
reviewed
Aug 4, 2022
jogerh
left a comment
There was a problem hiding this comment.
This makes quite a lot of sense. I agree that it should be the responsibility of the host to register the interfaces that it provides. But do you see this as a change that we would implement for all loaders, or just for the dummy loader?
…able marshsaling of the corresponding interfaces.
760a558 to
78e1890
Compare
Member
Author
All loaders will likely need to be updated the same or in a similar way. Hosts may also need to be updated to ensure that they're instead registering the interfaces if not done by the loaders any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done to prevent the loader from "hijacking" the registration of the
IImage3dSourceandIImage3dFileLoaderinterfaces that should really be the responsibility of the "host" SW to register.How SW implementation suggestion
Host SW that already registers COM classes can just add the IImage3dSource and IImage3dFileLoader to the
librarysection of their IDL file to auto-register the interfaces.Host SW that is not registering any COM classes can instead add the following C++ code: