fix(webhooks): ignore unhandled event types - #186
Open
pttydou wants to merge 1 commit into
Open
Conversation
|
@pttydou is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124.
handleEventunconditionally marked every verified event in its non-pull_requestbranch asPROCESSED, even though onlyissuesran a handler there. This change makesissuesthe second handled branch and marks all other verified event typesIGNOREDwithout settingprocessedAt. Existingpull_request,issues, and invalid-signature behavior is preserved.Tests:
node node_modules/jest/bin/jest.js src/github/github-webhooks.service.spec.ts --runInBand(12 passed)node node_modules/jest/bin/jest.js src/github --runInBand(34 passed)node node_modules/jest/bin/jest.js --runInBand --testPathIgnorePatterns=integration(166 passed)node node_modules/eslint/bin/eslint.js "{src,apps,libs,test}/**/*.ts" --fix(0 errors; 22 pre-existing e2e warnings)node node_modules/@nestjs/cli/bin/nest.js buildI couldn't run the seven Postgres integration tests locally because this environment has no Docker/Postgres. The remaining 169 tests passed in the full Jest run; CI provides Postgres 16.