Skip to content

fix(webhooks): ignore unhandled event types - #186

Open
pttydou wants to merge 1 commit into
MergeFi:mainfrom
pttydou:fix/issue-124-unrecognized-webhooks
Open

fix(webhooks): ignore unhandled event types#186
pttydou wants to merge 1 commit into
MergeFi:mainfrom
pttydou:fix/issue-124-unrecognized-webhooks

Conversation

@pttydou

@pttydou pttydou commented Aug 23, 2026

Copy link
Copy Markdown

Fixes #124.

handleEvent unconditionally marked every verified event in its non-pull_request branch as PROCESSED, even though only issues ran a handler there. This change makes issues the second handled branch and marks all other verified event types IGNORED without setting processedAt. Existing pull_request, issues, and invalid-signature behavior is preserved.

Tests:

  • node node_modules/jest/bin/jest.js src/github/github-webhooks.service.spec.ts --runInBand (12 passed)
  • node node_modules/jest/bin/jest.js src/github --runInBand (34 passed)
  • node node_modules/jest/bin/jest.js --runInBand --testPathIgnorePatterns=integration (166 passed)
  • node node_modules/eslint/bin/eslint.js "{src,apps,libs,test}/**/*.ts" --fix (0 errors; 22 pre-existing e2e warnings)
  • node node_modules/@nestjs/cli/bin/nest.js build

I couldn't run the seven Postgres integration tests locally because this environment has no Docker/Postgres. The remaining 169 tests passed in the full Jest run; CI provides Postgres 16.

@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

@pttydou is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GithubWebhooksService.handleEvent marks unrecognized webhook event types as PROCESSED even though nothing was done

1 participant