#151 varchar length caps, #164 always run E2E, #160/#162 milestones contract groundwork - #221
Merged
Merged
Conversation
|
@thefadah is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151, Fixes #164, Fixes #160, Fixes #162.
#151 — free-text DTO fields have no
@MaxLength(), entity columns no varchar lengthTeamMemberSplitDto.role→@MaxLength(50); columnvarchar(50)CreateMilestoneDto.title→@MaxLength(200); columnvarchar(200)CreateMilestoneDto.description→@MaxLength(2000)(column staystext)CreatePoolDto.name→@MaxLength(100); columnvarchar(100)1784800000000-BoundFreeTextColumnLengthsapplies theALTER COLUMN ... TYPE character varying(N)for existing databases.#164 — CI's E2E step has never run
Gating
npm run test:e2eonGITHUB_CLIENT_ID/GITHUB_CLIENT_SECRET(never configured as repo secrets) meant theelsebranch was never reached. The e2e specs run against the local Postgres service + mocked Stellar SDK and use neither secret, so the step now runsnpm run test:e2eunconditionally and its failure fails the pipeline.#160 / #162 — milestones vs. the real
mergefi-milestonescontractFull resolution needs
MilestonesServiceto track per-issue allocations (mirroring the real contract'sallocate/release_issue) instead of draining one ever-LOCKEDescrow via repeatedreleasePartial. This PR lands the groundwork and one concrete correctness fix:soroban-client.service.tsnow documents the realcreate_milestone/allocate/release_issueinterface alongside the escrow and maintenance-pool ones.resolveIssuenow rejects resolving an issue that is notopen— previously an already-resolved (CLOSED) issue could be resolved again, and paid again, as long as any other issue in the milestone was still open. This enforces the "each issue paid at most once" invariant the realrelease_issuehas.The per-issue-allocation data-model change is a larger follow-up.