Skip to content

test: cover milestone and maintenance edge cases - #207

Open
prissca wants to merge 1 commit into
MergeFi:mainfrom
prissca:test/prissca-mergefi-edge-errors-81-83-95
Open

test: cover milestone and maintenance edge cases#207
prissca wants to merge 1 commit into
MergeFi:mainfrom
prissca:test/prissca-mergefi-edge-errors-81-83-95

Conversation

@prissca

@prissca prissca commented Aug 26, 2026

Copy link
Copy Markdown

Summary

  • mark escrow, milestones, and maintenance-pool public Error enums as non-exhaustive
  • add milestones tests for fee_bps > 10000 and zero-fee full payout
  • add maintenance-pool coverage for get_pool and withdraw on missing pool IDs

Tests

  • cargo fmt
  • git diff --check
  • cargo test -p mergefi-milestones -p mergefi-maintenance-pool (blocked locally: Windows MSVC linker link.exe is not installed)

Closes #81
Closes #82
Closes #83
Closes #95

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

@Obiajulu-gif is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@prissca Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants