fix(a11y): fix heading hierarchy skips and add descriptive button aria-labels (#280, #281, #282) - #290
Open
ghzhost wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses accessibility and semantic heading hierarchy issues across the issues and milestones routes:
/issues(BountyCard's h3 title skips directly from the page's h1 with no intervening h2, breaking heading-level navigation on /issues #281): Added an intermediate visually-hidden<h2>(Bounties list) before the bounty grid so screen readers navigating by heading level do not encounter a jump from<h1>directly to<h3>./milestones(MilestonesPage's milestone card titles also skip from h1 directly to h3 with no h2 in between #282): Added an intermediate visually-hidden<h2>(Active milestones) before the milestones grid to maintain logical level order before reaching individual<h3>milestone titles.MilestoneFundButtonandPoolDepositButtonto provide explicit, context-richaria-labelattributes (aria-label={Fund ${milestoneName}}andaria-label={Deposit to ${poolRepo} pool}), allowing screen reader users navigating by interactive controls to distinguish buttons out of context.Closes #280
Closes #281
Closes #282