Fixes for the layer legend#4484
Open
uclaros wants to merge 7 commits into
Open
Conversation
📦 Build Artifacts Ready
|
uclaros
marked this pull request as draft
April 29, 2026 15:25
uclaros
marked this pull request as ready for review
May 7, 2026 14:41
Coverage Report for CI Build 25502822581Coverage decreased (-0.07%) to 57.854%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions49 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Jul 16, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Let's try another rebase :)
| double number720() const {return 720 * mDp;} | ||
|
|
||
| double scrollVelocityAndroid() const { return 10000; } | ||
| static double scrollVelocityAndroid() { return 10'000; } |
Collaborator
There was a problem hiding this comment.
this is probably a typo
Comment on lines
+105
to
+111
| QgsTextFormat textFormat = legendSettings.rstyle( QgsLegendStyle::Style::SymbolLabel ).textFormat(); | ||
| textFormat.setSize( 14 ); // 14 is the pixel size of MMStyle::p5, used in form widgets | ||
| textFormat.setSizeUnit( Qgis::RenderUnit::Pixels ); | ||
| textFormat.setColor( MMStyle::nightColor() ); | ||
| legendSettings.rstyle( QgsLegendStyle::Style::SymbolLabel ).setTextFormat( textFormat ); | ||
| legendSettings.rstyle( QgsLegendStyle::Style::SymbolLabel ).setMargin( 4 ); // match the top and left total margin of the legend | ||
| legendSettings.rstyle( QgsLegendStyle::Style::Title ).setMargin( 0 ); // Our empty Title still adds some margins, so we set those to zero |
Collaborator
There was a problem hiding this comment.
Looks like QgsLegendStyle::Style enum doesn't exist anymore in QGIS 3.44 -> QGIS PR
|
|
||
| QPainter painter( &legend ); | ||
| painter.setRenderHint( QPainter::Antialiasing ); | ||
| { |
Collaborator
There was a problem hiding this comment.
out of curiosity what's the reason for having this part of the code wrapped in extra curly braces?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust the legend text size, color and margins.