Feature/clear button for calendar drawers#4572
Open
xkello wants to merge 4 commits into
Open
Conversation
Coverage Report for CI Build 29329505714Coverage decreased (-0.1%) to 58.992%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions22 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Jul 1, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Welcome to the jungle!
Collaborator
|
Also the the clear text is not horizontally aligned with the rest of header and the text color is wrong |
📦 Build Artifacts Ready
|
Withalion
reviewed
Jul 17, 2026
| function hasValidFieldValue() { | ||
| return root._fieldValueIsNull | ||
| || root._fieldHasMixedValues | ||
| || (root._fieldValue ?? null) === null |
Collaborator
There was a problem hiding this comment.
Suggested change
| || (root._fieldValue ?? null) === null | |
| || root._fieldValue ?? true |
this should be the same
| } | ||
| } | ||
|
|
||
| function hasValidFieldValue() { |
Collaborator
There was a problem hiding this comment.
It would make more sense to call it invalid values
| } | ||
|
|
||
| onClearButtonClicked: { | ||
| root.editorValueChanged( undefined, true ) |
Collaborator
There was a problem hiding this comment.
is there a reason we can't use null? If not then let's prefer using null
Collaborator
There was a problem hiding this comment.
can you as well purge the openCalendar() method only keep forceActiveFocus() and then from openPicker() take the contents and put everything in openCalendar(). Remove openPicker()
| dim: true | ||
|
|
||
| drawerHeader.title: root.title | ||
| drawerHeader.topLeftItem.visible: !root.showClearButton |
Collaborator
There was a problem hiding this comment.
the logic of visibility is opposite to the naming of the variable, it should match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There was no way to remove value/set it as null for date field in calendar drawers. Users had to reopen the drawer by creating exactly the same point on the map for example.
Clearing the date field is causing runtime error.
Solution
Added a clear button in the drawer in header space.
Added guards which check for
undefinedandnull_fieldValuebefore assigningdateTimein calendar drawer.Behavior
Images for part 1
Video for part 1
Screencast.From.2026-06-30.17-43-27.webm