Skip to content

Feature/multiline description support#4593

Open
xkello wants to merge 2 commits into
masterfrom
feature/multiline-description-support
Open

Feature/multiline description support#4593
xkello wants to merge 2 commits into
masterfrom
feature/multiline-description-support

Conversation

@xkello

@xkello xkello commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Description

Long description values in value map or value relation fields were truncated in the selection dialog, with no way to add line breaks. This forced users to shorten their descriptions to avoid cut-off text.

Ticket: #4502

IMG_4764 IMG_4763 IMG_4762

What changed

In app/qml/components/MMListDelegate.qml, both the primary and secondary Text elements now support multi-line wrapping instead of single-line truncation.
Text.Wrap was selected as it seemed the most appropriate of the three wrap methods, since users may use snake_case or similar naming conventions in their descriptions.

Screenshot_20260712-194517 Screenshot_20260712-194508 Screenshot_20260712-194458

Expected behaviour

Descriptions now support line breaks/wrapping so multi-line text displays properly
List item height expands to accommodate up to 3 lines of text without truncation
Only descriptions exceeding 3 lines get truncated with an ellipsis (...), instead of the previous 1-line limit

@xkello
xkello requested a review from Withalion July 12, 2026 18:05
@github-actions

Copy link
Copy Markdown

Coverage Report for CI Build 29202718672

Coverage increased (+0.1%) to 59.128%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 3 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
mm/core/merginapi.cpp 3 75.3%

Coverage Stats

Coverage Status
Relevant Lines: 15639
Covered Lines: 9247
Line Coverage: 59.13%
Coverage Strength: 97.34 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 70141 dmg Expires: 10/10/2026 #7014
linux Build 📬 Mergin Maps 70401 x86_64 Expires: 10/10/2026 #7040
win64 Build 📬 Mergin Maps 62141 win64 Expires: 10/10/2026 #6214
Android Build 📬 Mergin Maps 832451 APK [arm64-v8a] Expires: 10/10/2026 #8324
📬 Mergin Maps 832451 APK [arm64-v8a] Google Play Store #8324
Android Build 📬 Mergin Maps 832411 APK [armeabi-v7a] Expires: 10/10/2026 #8324
📬 Mergin Maps 832411 APK [armeabi-v7a] Google Play Store #8324
iOS Build 📬 Build number: 26.07.926611 #9266

@xkello xkello linked an issue Jul 14, 2026 that may be closed by this pull request

@Withalion Withalion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sold on this solution as it enables 3 line text for a lot of stuff. Maybe we could expose some property, which would enable long descriptions if necessary. Then enable it for value map/relation editors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Value map/relation field: support multi-line descriptions

2 participants