Skip to content

Bugfix/hide private layers from dropdown #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xkello wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −0
Open

Bugfix/hide private layers from dropdown #4600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb6a611
Fix private layers being displayed in record layers dropdown
Jul 14, 2026
2081faf
Fix formating
Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/activeproject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,16 @@ bool ActiveProject::recordingAllowed( QgsMapLayer *layer ) const
if ( layer->readOnly() )
return false;

if ( layer )

@Withalion Withalion Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this condition is always true

{
bool isPrivate = layer->flags() & QgsMapLayer::LayerFlag::Private;

if ( isPrivate )
{
return false;
}
}

return QgsMapLayerProxyModel::layerMatchesFilters( layer, Qgis::LayerFilter::HasGeometry | Qgis::LayerFilter::WritableLayer ) && layer->id() != positionTrackingLayerId() && layer->id() != mapSketchesLayerId();
}

Expand Down
10 changes: 10 additions & 0 deletions app/recordinglayersproxymodel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ bool RecordingLayersProxyModel::filterAcceptsRow( int source_row, const QModelIn
QModelIndex index = mModel->index( source_row, 0, source_parent );
QgsMapLayer *layer = mModel->layerFromIndex( index );

if ( layer )
{
bool isPrivate = layer->flags() & QgsMapLayer::LayerFlag::Private;

if ( isPrivate )
{
return false;
}
}

return mModel->data( index, LayersModel::LayerVisible ).toBool();
}

Expand Down
Loading